Wolf Faction

General

About this site
Login
Register

Forum

All Forums
FAQ

My stuff

Out-of-Character Information

General
New Picture Gallery
Old Picture Gallery
Events
Links
 

All times are UTC



Post new topic Reply to topic  [ 9 posts ] 
Author Message
 Post subject: [BUG] IC Names being displayed incorrectly when quoting.
PostPosted: Fri Jun 03, 2016 11:43 am 
Offline
Member
User avatar

Joined: Wed Jun 01, 2005 3:07 pm
Posts: 497
Location: Chester
Real Name: Pete Matthews
What is the bug?

In in-character forums, when quoting someone, your character name is changed to the username of the person you quoted.

What would you expect?

The character name to be displayed, rather than the username of the person you quoted.

Where can this bug been seen?

Subject: Research over Summer - please offer your thoughts

_________________
Lord Ronan 'Diego' Tyrnhand, Godhi of Tyr, Treasurer for The Shian Wolves.

"Damn you King Oberron; you've caused me more hassle this weekend than a half naked pirate!" -- GEF 1115


Top
 Profile E-mail  
 
 Post subject: Re: [BUG] IC Names being displayed incorrectly when quoting.
PostPosted: Fri Jun 03, 2016 11:46 am 
Offline
Member
User avatar

Joined: Wed Jun 01, 2005 3:07 pm
Posts: 497
Location: Chester
Real Name: Pete Matthews
Apologies, I've just realised this was posted in the wrong board.

_________________
Lord Ronan 'Diego' Tyrnhand, Godhi of Tyr, Treasurer for The Shian Wolves.

"Damn you King Oberron; you've caused me more hassle this weekend than a half naked pirate!" -- GEF 1115


Top
 Profile E-mail  
 
 Post subject: Re: [BUG] IC Names being displayed incorrectly when quoting.
PostPosted: Fri Jun 03, 2016 12:10 pm 
Offline
Member

Joined: Tue Apr 28, 2015 11:48 am
Posts: 61
Real Name: ATLAS
to correct it you need to edit your post and re do it, it corrects it. its done it to me a few times

_________________
VLAD

Something and Nothing
carry on don't mind me


Top
 Profile E-mail  
 
 Post subject: Re: [BUG] IC Names being displayed incorrectly when quoting.
PostPosted: Fri Jun 03, 2016 2:29 pm 
Offline
Site Admin
User avatar

Joined: Tue Feb 03, 2004 1:24 pm
Posts: 9442
Location: North Herts / South Jotunheim
Real Name: Dave Miller
I'll leave this here just so other people can see it.


Yeah, it's a bug but it's all fluff, so live with it, I'm not inclined to fix it in the forseeable.
I added the IC name thing in a way that was easy to use what was already there in phpBB
Type the right stuff in first time, and use preview.


Top
 Profile E-mail  
 
 Post subject: Re: [BUG] IC Names being displayed incorrectly when quoting.
PostPosted: Fri Jun 03, 2016 4:57 pm 
Offline
Site Admin
User avatar

Joined: Tue Feb 03, 2004 11:15 am
Posts: 2050
Location: Birmingham, UK
Real Name: Rich Gaunt
I think you actually fixed some hack that I put in waaaay back and made it all work when we ported to the new version of PhpBB.

That's more impressive than just writing it in the first place, as I doubt I properly commented what I did. :D


Top
 Profile E-mail  
 
 Post subject: Re: [BUG] IC Names being displayed incorrectly when quoting.
PostPosted: Fri Jun 03, 2016 7:44 pm 
Offline
Member
User avatar

Joined: Wed Jun 01, 2005 3:07 pm
Posts: 497
Location: Chester
Real Name: Pete Matthews
I have done something similar with phpBB3, using the custom profile fields. It's a real pain to manage though. I feel your pain.

_________________
Lord Ronan 'Diego' Tyrnhand, Godhi of Tyr, Treasurer for The Shian Wolves.

"Damn you King Oberron; you've caused me more hassle this weekend than a half naked pirate!" -- GEF 1115


Top
 Profile E-mail  
 
 Post subject: Re: [BUG] IC Names being displayed incorrectly when quoting.
PostPosted: Fri Jun 03, 2016 11:07 pm 
Offline
Site Admin
User avatar

Joined: Tue Feb 03, 2004 1:24 pm
Posts: 9442
Location: North Herts / South Jotunheim
Real Name: Dave Miller
Yeah, it's not via custom profile fields, phpBB has "more than one user field" on a post.
Setting a "different value to the actual user posting" isn't too bad on the inital post, but on the edit operation "things work differently".


Top
 Profile E-mail  
 
 Post subject: Re: [BUG] IC Names being displayed incorrectly when quoting.
PostPosted: Sat Jun 04, 2016 2:45 am 
Offline
Member
User avatar

Joined: Wed Jun 01, 2005 3:07 pm
Posts: 497
Location: Chester
Real Name: Pete Matthews
I had to add in a flag to each forum saying whether it was IC or OC, then add a new field and checkbox to the forum creation admin page.

I then added if...else blocks to see whether that flag was said, if it was, it displayed the IC info from the character profile, rather than the user profile info. It meant you could have IC/OC signatures, avatars, post counts, names, and pretty much whatever you wanted.

With phpBB though, it's really cumbersome. The custom profile fields in phpBB3 helped, but it was still a huge hassle. I ended up scrapping the project, as there was a really good ASP.NET forum that fed straight from EntityFramework. Long time ago now though.

I admire the work you've done to customise this forum, I hate to think of the mess made when porting it over from phpBB2. So many breaking changes. :(

_________________
Lord Ronan 'Diego' Tyrnhand, Godhi of Tyr, Treasurer for The Shian Wolves.

"Damn you King Oberron; you've caused me more hassle this weekend than a half naked pirate!" -- GEF 1115


Top
 Profile E-mail  
 
 Post subject: Re: [BUG] IC Names being displayed incorrectly when quoting.
PostPosted: Sat Jun 04, 2016 12:36 pm 
Offline
Site Admin
User avatar

Joined: Tue Feb 03, 2004 1:24 pm
Posts: 9442
Location: North Herts / South Jotunheim
Real Name: Dave Miller
IIRC 2 to 3 wasn't so bad. There was something about upper/lower case in templating variables now mattering.
There is an IC flag for things but also just standard setting a different theme on the forum.

Ofc most of the custom stuff is in the huge "back office" system that handles bookings and things.


Top
 Profile E-mail  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 9 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group